-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poco-chain with poco v5.5.0 and voucher v1.0.0 in tests #106
Open
nabil-Tounarti
wants to merge
7
commits into
develop
Choose a base branch
from
feature/poco-v5.5.0-and-voucher-v1.0.0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabil-Tounarti
changed the title
se poco-chain with poco v5.5.0 and voucher v1.0.0 in tests
Use poco-chain with poco v5.5.0 and voucher v1.0.0 in tests
Oct 23, 2024
jbern0rd
reviewed
Oct 23, 2024
jbern0rd
reviewed
Oct 25, 2024
CHANGELOG.md
Outdated
@@ -30,6 +30,7 @@ All notable changes to this project will be documented in this file. | |||
- Restrict several methods visibility in `IexecHubAbstractService`. (#96) | |||
- Avoid exceptions during `IexecHubAbstractService` and `Web3jAbstractService` objects creation. (#99) | |||
- Improve `SignatureUtils`: remove dead code and remove cleanly unused parameter in `hashAndSign`. (#100) | |||
- Use `poco-chain` with `poco v5.5.0` and `voucher v1.0.0` in tests (#106) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Use `poco-chain` with `poco v5.5.0` and `voucher v1.0.0` in tests (#106) | |
- Use `poco-chain` with `poco v5.5.0` and `voucher v1.0.0` in tests. (#106) |
Quality Gate passedIssues Measures |
jbern0rd
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.